✨ Implement ZkSync Ignite incentives program #2305
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@MartinGbz is attempting to deploy a commit to the Avara Team on Vercel. A member of the Team first needs to authorize it. |
|
@MartinGbz this link here seems to not work https://app.zksyncignite.xyz/users/ |
| <Typography variant="caption" color="text.secondary" mb={3}> | ||
| <Trans>ZKSync Ignite Program rewards are claimed through the</Trans>{' '} | ||
| <Link | ||
| href="https://app.zksyncignite.xyz/users/" |
There was a problem hiding this comment.
This link here wasn't working. Is that expected? @MartinGbz
There was a problem hiding this comment.
Yes, it's expected. Link was provided by my Merkl team and will be activated at the beginning of the Ignite program
| @@ -61,6 +63,35 @@ export const MeritIncentivesButton = (params: { | |||
| ); | |||
| }; | |||
|
|
|||
| export const ZkIgniteIncentivesButton = (params: { | |||
| market: string; | |||
| asset?: string; | |||
There was a problem hiding this comment.
I see we are passing the term asset around. Can we make it more explicit like rewardAsset or something similar. This way its easier to understand when we are passing this variable @MartinGbz
There was a problem hiding this comment.
Agree with you
Asset here can be the aToken or the vToken (aave asset in any cases). If it was the underlying asset I would set it for underlyingAsset.
I can set it to rewardedAsset what do you think?
There was a problem hiding this comment.
Pushed a commit: f2dad18
| <IncentivesCard | ||
| value={Number(variableBorrowRate)} | ||
| incentives={vIncentivesData} | ||
| address={variableDebtTokenAddress} |
There was a problem hiding this comment.
this is only used for the zksync incentives right?
|
❌ CI run has failed! |
General Changes
The PR adds a new ZkSync Ignite Incentives tooltip in order to display the APRs of the program.
Here's a quick preview of the incentives with an APR of 2%:
Resources
Twitter account: https://x.com/ZKsyncIgnite
Website: https://zksyncignite.xyz/
Forum: https://forum.zknation.io/t/tpp-001-zksync-ignite-program-the-ignite-program/168/2
Developer Notes
A small refactor has been done in order to avoid copy paste this new IncentivesButton in all related components. Now all IncentivesButtons are only specified in the
IncentivesCardcomponent.Moreover this small refactor allow to fix IncentivesButtons disposition. Because before the max number of button could be max 2 (Native Aave LM + Merit LM), now the max number of button ca be 3 (Native LM + Merit + ZKIgnite + maybe more in the future).
To fix this, we now set a flexbox column with 1 element per row on buttons on Mobile, and with 2 elements max per row on computer. Here's some screenshot that showcase it:
Mobile:
Computer:
Reviewer Checklist
Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.
.env.examplefile as well as the pertinant.github/actions/*files