Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary slash in explorer links [skip cypress] #2316

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

CanonicalJP
Copy link
Contributor

General Changes

  • Fixes extra slash in explorer link for base_sepolia, bnb, scroll, and zksync

Developer Notes

Related to #2315


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:48am
interface-ez7q ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2025 10:48am

Copy link

Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

🎉 Global Bundle Size Decreased

Page Size (compressed)
global 857.97 KB (-4 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@foodaka
Copy link
Collaborator

foodaka commented Jan 16, 2025

@CanonicalJP can you link the issue so it closes, thanks!

@grothem grothem changed the title Remove unnecessary slash in explorer links Remove unnecessary slash in explorer links [skip cypress] Jan 16, 2025
@grothem grothem merged commit 1de2efc into main Jan 16, 2025
22 of 23 checks passed
@grothem grothem deleted the fix/explorer-links branch January 16, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary slash at the end of explorer link leads to incorrect final link
3 participants