fix: Subject.get_semantic_iri

should use the iri for a subject's bepress synonym only when it has the
exact same text -- it was instead doing the opposite

api_tests/subjects/views/test_subject_detail.py

@@ -44,6 +44,7 @@ def test_get_subject_detail(self, app, url_subject_detail, subject, subject_chil
         assert 'parent' in data['relationships']
         assert data['relationships']['parent']['data'] is None
         assert data['relationships']['children']['links']['related']['meta']['count'] == 2
+        assert data['links']['iri'] == subject.get_semantic_iri()
 
         # Follow children link
         children_link = data['relationships']['children']['links']['related']['href']

osf/models/subject.py

@@ -57,7 +57,7 @@ def get_absolute_url(self):
     def get_semantic_iri(self) -> str:
         _identified_subject = (
             self.bepress_subject
-            if self.bepress_subject and (self.text != self.bepress_subject.text)
+            if self.bepress_subject and (self.text == self.bepress_subject.text)
             else self
         )
         return _identified_subject.absolute_api_v2_subject_url.rstrip('/')

tests/test_subjects.py

@@ -175,3 +175,19 @@ def test_path(self):
         assert self.bepress_child.path == 'bepress|BePress Text|BePress Child'
         assert self.other_subj.path == 'asdf|Other Text'
         assert self.other_child.path == 'asdf|Other Text|Other Child'
+
+    def test_get_semantic_iri(self):
+        _bepress_iri = self.bepress_subj.get_semantic_iri()
+        _other_iri = self.other_subj.get_semantic_iri()
+        assert _bepress_iri != _other_iri
+        assert _bepress_iri.endswith(self.bepress_subj._id)
+        assert _other_iri.endswith(self.other_subj._id)
+
+        # if a subject has the exact same text as its bepress synonym, expect the bepress subject iri
+        _sametext_subj = SubjectFactory(
+            text=self.bepress_subj.text,
+            bepress_subject=self.bepress_subj,
+            provider=self.asdf_provider,
+        )
+        _sametext_iri = _sametext_subj.get_semantic_iri()
+        assert _bepress_iri == _sametext_iri