searching for tracks considers the search pattern in filenames too #818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hurzl
reviewed
Jan 9, 2017
|
|
||
| try { | ||
| arrayMusic = mApp.oMPDAsyncHelper.oMPD.search("any", finalSearch); | ||
| } catch (final IOException | MPDException e) { | ||
| Log.e(TAG, "MPD search failure.", e); | ||
|
|
||
| } | ||
|
|
||
| if (arrayMusic == null) { | ||
| return; |
There was a problem hiding this comment.
if it returns here you don't get the chance to match the filename ...
There was a problem hiding this comment.
Thats right, but i thought arrayMusic is only null if an error occured (exception catched) and i don't wanted to do another search in that case. arrayMusic should be an empty list if nothing was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Searching for tracks currently uses the MPD search command with type "any". The type "any" only considers tags like id3 or something. The type "filename" is a special type not included by "any". This pull request allows MPDroid to find files with the matching search pattern in filenames too.