Feature: Genre optimization #836
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What are the default delimiter chars? |
|
Hello! Thanks for all of your pull requests. I noticed you're doing quite a lot of them, some of which I'd be inclined to merge and some I'm not sure about. As you may have noticed, MPDroid is no longer active development, meaning that I don't also take time to really review the merge requests, something essential for merging them. While I really appreciate the contributions, I think it may be for the best that you and some other people working on mpdroid on their end may look into forking it for good |
|
The default delimiter characters are / , ; | + |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ID3 tagging does not support multiple genre values. To tag anyway multiple genres you have to separate them by some delimiter. Thus browsing by genre becomes difficult:
I have added a feature to optimize the genre browsing. It can be enabled/disabled via Preferences (also the delimiter characters). Each genre value will split and shown as a single genre:
Browsing the genre 'Pop' shows all artists that match one of the three complex genres that contains 'Pop': 'Pop', 'pop / rock' & 'Indie, Alternative, Pop'.
In the implementation
GenreGroupis used instead ofGenreby the browsing fragments.