Ipad 508 enable model designation for multimodel plots #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plemented in check.R and validate.R
|
Is this purposefully being submitted against the "dev" branch? If yes, it would be nice if someone could sync the dev branch so only the new changes are displayed in the PR's diff for review. |
I've just synced the dev branch with main, thanks @jdblischak |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create validation tests to verify models field, part of the plots object used in addPlots, match requirements.
Essentially, "all" is the models default. If models != 'all', then plotType must contain 'multiModel' (checks.R)
Also, if models != 'all', models must contain model names as found in column names from mapping object. First, it searches for mapping object with the same name as the modelname found in the plots object (added to addPlots), if not found, it takes mapping object named as 'default'.