-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vite #173
Draft
drzax
wants to merge
5
commits into
main
Choose a base branch
from
vite
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Vite #173
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// Ours | ||
const { cmd, hvy, opt, sec } = require('../../utils/color'); | ||
|
||
const BUNDLE_ANALYZER_CONFIG = (module.exports.BUNDLE_ANALYZER_CONFIG = { | ||
analyzerHost: '127.0.0.1', | ||
logLevel: 'error', | ||
openAnalyzer: false | ||
}); | ||
|
||
module.exports.MESSAGES = { | ||
port: port => `Port ${port} already in use attempting to use port ${port + 1}`, | ||
analysis: ({ analyzerHost, analyzerPort }) => `http://${analyzerHost}:${analyzerPort}`, | ||
serve: ({ bundleAnalysisPath, hot, publicPath }) => `Serve (${hvy(process.env.NODE_ENV)}):${ | ||
bundleAnalysisPath | ||
? ` | ||
┣ ${hvy('bundle analysis')}: ${bundleAnalysisPath}` | ||
: '' | ||
} | ||
┣ ${hvy('hot')}: ${cmd(hot ? 'yes' : 'no')} | ||
┗ ${hvy('publicPath')}: ${publicPath}`, | ||
// TODO: Add aunty config section to usage | ||
usage: name => `Usage: ${cmd(`aunty ${name}`)} ${opt('[options]')} | ||
|
||
${sec('Options')} | ||
|
||
${opt('-d')}, ${opt('--dry')} Output the generated webpack & dev server configuration, then exit | ||
|
||
${sec('Environment variables')} | ||
|
||
• Builds will assume you have set ${cmd('NODE_ENV=development')}, unless you specify otherwise. | ||
• You can override the host and port the server listens on by setting ${cmd('AUNTY_HOST')} and ${cmd('AUNTY_PORT')}. | ||
` | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,97 @@ | ||
// External | ||
const importLazy = require('import-lazy')(require); | ||
const { createServer } = importLazy('vite'); | ||
|
||
// TODO: add budle analyzer https://github.com/btd/rollup-plugin-visualizer | ||
// const { BundleAnalyzerPlugin } = require('webpack-bundle-analyzer'); | ||
|
||
// Ours | ||
const { getServeConfig } = require('../../config/serve'); | ||
const { getViteConfig } = require('../../config/vite'); | ||
const { throws } = require('../../utils/async'); | ||
const { cmd } = require('../../utils/color'); | ||
const { dry, info, spin } = require('../../utils/logging'); | ||
const { combine } = require('../../utils/structures'); | ||
const { command } = require('../'); | ||
const cleanCommand = require('../clean'); | ||
const { MESSAGES } = require('./constants'); | ||
const { getViteServerConfig } = require('../../config/viteServer'); | ||
|
||
module.exports = command( | ||
{ | ||
name: 'serve-vite', | ||
nodeEnv: 'development', | ||
usage: MESSAGES.usage | ||
}, | ||
async argv => { | ||
const { port } = await getServeConfig(); | ||
const viteConfig = getViteConfig(); | ||
viteConfig.server = await getViteServerConfig(); | ||
|
||
if (argv.dry) { | ||
return dry({ | ||
'Vite config': viteConfig | ||
}); | ||
} | ||
|
||
throws(await cleanCommand(['--quiet'])); | ||
|
||
info( | ||
MESSAGES.serve({ | ||
hot: viteConfig.server.hmr, | ||
publicPath: viteConfig.base | ||
}) | ||
); | ||
|
||
const server = await createServer(viteConfig); | ||
const [gracefullyInterrupt, restore] = gracefullyHandleLogging(); | ||
|
||
return new Promise(async (resolve, reject) => { | ||
try { | ||
await server.listen(port); | ||
server.printUrls(); | ||
} catch (err) { | ||
return reject(err); | ||
} | ||
|
||
spinner = spin('Server running'); | ||
gracefullyInterrupt(spinner); | ||
|
||
process.on('SIGINT', async () => { | ||
spinner.clear(); | ||
await server.close(); | ||
if (spinner) { | ||
spinner.succeed('Server closed'); | ||
} | ||
|
||
resolve(); | ||
}); | ||
}).finally(() => restore()); | ||
} | ||
); | ||
|
||
const gracefullyHandleLogging = () => { | ||
const METHODS = ['debug', 'error', 'info', 'log', 'warn']; | ||
const reference = {}; | ||
|
||
for (let method of METHODS) { | ||
reference[method] = console[method]; | ||
} | ||
|
||
return [ | ||
spinner => { | ||
for (let method of METHODS) { | ||
console[method] = (...args) => { | ||
spinner.clear(); | ||
reference[method](...args); | ||
spinner.start(); | ||
}; | ||
} | ||
}, | ||
() => { | ||
for (let method of METHODS) { | ||
console[method] = reference[method]; | ||
} | ||
} | ||
]; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
getViteConfig
abstraction looks great. It could make it really easy to just optionally add a build.lib config object for apackage
style command (similarly to how sveltekit lets you publish thelib
folder as a library