Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: when multiple video blocks crossfade, only the first plays #19

Closed
wants to merge 2 commits into from
Closed

bug: when multiple video blocks crossfade, only the first plays #19

wants to merge 2 commits into from

Conversation

AshKyd
Copy link
Member

@AshKyd AshKyd commented Feb 13, 2024

This works for the use case but it's not well tested.

  1. should we have a clearer distinction between which videos use the mutation vs intersection observer?
  2. need to double-check this isn't running the fade in/out vids multiple times.

@AshKyd AshKyd requested a review from phocks February 13, 2024 06:02
phocks
phocks approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@phocks phocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Clever to use mutation observer.

jtfell
jtfell approved these changes Feb 16, 2024
View reviewed changes
Copy link

@jtfell jtfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM - keen to try it out on the TikTok story

@AshKyd
Copy link
Member Author

AshKyd commented Feb 20, 2024

Closing this in favour of #20

@AshKyd AshKyd closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtfell jtfell jtfell approved these changes

@phocks phocks phocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AshKyd @phocks @jtfell