Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel data change fix #45

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Panel data change fix #45

wants to merge 4 commits into from

Conversation

phocks
Copy link
Member

@phocks phocks commented Aug 10, 2022

Fixes #44 but it's a bit hacky. Prefer a proper fix if @drzax reckons we need the ability to alter panels after initial load and have the data come through onMarker.

@phocks phocks requested a review from drzax August 10, 2022 06:12
@github-actions
Copy link

size-limit report 📦

Path Size
dist/scrollyteller.cjs.production.min.js 4.08 KB (+0.22% 🔺)
dist/scrollyteller.esm.js 3.99 KB (+0.3% 🔺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current marker data doesn't change when panel props change
1 participant