Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API is now promises only #4

Merged
merged 1 commit into from
Oct 7, 2024
Merged

API is now promises only #4

merged 1 commit into from
Oct 7, 2024

Conversation

drzax
Copy link
Member

@drzax drzax commented Oct 4, 2024

  • Minor type improvements
  • Extremely minor extention to test coverage

@drzax
API is now promises only
32ffc0e 
- Minor type improvements
- Extremely minor extention to test coverage
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 4, 2024

size-limit report 📦

Path Size
dist/index.mjs 2.03 KB (-4.86% 🔽)
dist/index.js 3.03 KB (-3.61% 🔽)

phocks
phocks approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@phocks phocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I like it. A lot cleaner.

jtfell
jtfell approved these changes Oct 7, 2024
View reviewed changes
Copy link

@jtfell jtfell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drzax drzax merged commit 84fa3e5 into main Oct 7, 2024
5 checks passed
@drzax drzax deleted the promises-only branch October 7, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtfell jtfell jtfell approved these changes

@phocks phocks phocks approved these changes

@AshKyd AshKyd AshKyd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@drzax @AshKyd @phocks @jtfell