Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Interface with CRYPTOPP_INSTALL_PREFIX definition and Added test for compilation with prefix #16

Merged
merged 1 commit into from
Aug 30, 2022

Conversation

Vollstrecker
Copy link
Collaborator

k, I now added the Interface and the code in the test to use it. This could also be the example you need for #9 (thanks to aMule). If I see this correct, the find-package test is run after all install tests, so it picks up the one with the prefix.

@abdes Have you an idea to reorder the tests so first all without and then all with prefix are run? Or do you think one test that uses the defined prefix from the interface is enough? Imho the code doesn't care about what is defined as long as a header is found, so testing this twice could be just dropped.

@Vollstrecker Vollstrecker requested a review from abdes August 29, 2022 20:53
@abdes
Copy link
Owner

abdes commented Aug 30, 2022

@abdes Have you an idea to reorder the tests so first all without and then all with prefix are run? Or do you think one test that uses the defined prefix from the interface is enough? Imho the code doesn't care about what is defined as long as a header is found, so testing this twice could be just dropped.

As you said, the code does not really care, so there is no point in reordering. As long as the unit tests using prefix pass, it's ok.

@Vollstrecker Vollstrecker merged commit c7fa777 into master Aug 30, 2022
@Vollstrecker Vollstrecker deleted the prefix-test branch August 30, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants