Fix isolate build + components build on windows (#28559)

Esbuild requires these values to be reasonable like this to work on windows. Cross platform - what a headache! GitOrigin-RevId: 290db0ec5702852ba60b5a7c8155687a2a3a36ed
abdulrahman305 · Aug 1, 2024 · db55dce · db55dce
1 parent b1a92ec
commit db55dce
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/src/cli/lib/components/definition/bundle.ts b/src/cli/lib/components/definition/bundle.ts
@@ -177,8 +177,8 @@ const SHARED_ESBUILD_OPTIONS = {
 
   // place output files in memory at their source locations
   write: false,
-  outdir: "/",
-  outbase: "/",
+  outdir: path.parse(process.cwd()).root,
+  outbase: path.parse(process.cwd()).root,
 
   minify: true,
   keepNames: true,

diff --git a/src/cli/lib/components/definition/directoryStructure.ts b/src/cli/lib/components/definition/directoryStructure.ts
@@ -32,12 +32,7 @@ export function qualifiedDefinitionPath(
   workingDir = ".",
 ) {
   const definitionPath = path.relative(workingDir, directory.definitionPath);
-  // A ./ or ../ prefix make a path "qualified."
-  if (definitionPath.startsWith("./") || definitionPath.startsWith("../")) {
-    return definitionPath;
-  } else {
-    return `./${definitionPath}`;
-  }
+  return `./${definitionPath}`;
 }
 
 // NB: The process cwd will be used to resolve the directory specified in the constructor.