Skip to content
PR golangci-lint

✨ Refactor bottlerocket settings templates into go structs #42

Sign in to view logs

✨ Refactor bottlerocket settings templates into go structs

✨ Refactor bottlerocket settings templates into go structs #42

Triggered via pull request August 6, 2024 23:16
@mitalipaygudemitalipaygude
edited #34
refactor_toml
Status Failure
Total duration 2m 8s
Artifacts –

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

30 errors and 12 warnings
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (hack/tools)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint (test)
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint
Cannot open: File exists
lint (hack/tools)
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
lint (test)
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
lint
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
lint: util/secret/consts.go#L55
exported: exported const ManagedExternalEtcdCA should have comment (or a comment on this block) or be unexported (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bootstrap.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bootstrap_test.go#L757
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L28
exported: type name will be used as bottlerocket.BottlerocketConfig by other packages, and that stutters; consider calling this Config (revive)
lint: controllers/external/util.go#L260
exported: exported function GetExternalEtcdEndpoints should have comment or be unexported (revive)
lint: controllers/external/util.go#L270
exported: exported function IsExternalEtcdUpgrading should have comment or be unexported (revive)
lint: controllers/external/util.go#L285
exported: exported function SetKCPUpdateCompleteAnnotationOnEtcdadmCluster should have comment or be unexported (revive)
lint: controlplane/kubeadm/internal/workload_cluster_etcd.go#L113
exported: exported method Workload.UpdateExternalEtcdEndpointsInKubeadmConfigMap should have comment or be unexported (revive)