✨ Refactor bottlerocket settings templates into go structs #44
mitalipaygudeAnnotations
10 errors and 10 warnings
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2291
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2292
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2378
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2415
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2416
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
controlplane/kubeadm/internal/controllers/controller_test.go#L2453
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
internal/controllers/cluster/cluster_controller_test.go#L1000
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
internal/controllers/cluster/cluster_controller_test.go#L1043
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
internal/controllers/cluster/cluster_controller_test.go#L1128
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
internal/controllers/cluster/cluster_controller_test.go#L1175
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
|
|
lint:
util/secret/consts.go#L55
exported: exported const ManagedExternalEtcdCA should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bootstrap.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L28
exported: type name will be used as bottlerocket.BottlerocketConfig by other packages, and that stutters; consider calling this Config (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bootstrap_test.go#L757
unused-parameter: parameter 't' seems to be unused, consider removing or renaming it as _ (revive)
|
|
lint:
controllers/external/util.go#L260
exported: exported function GetExternalEtcdEndpoints should have comment or be unexported (revive)
|
|
lint:
controllers/external/util.go#L270
exported: exported function IsExternalEtcdUpgrading should have comment or be unexported (revive)
|
|
lint:
controllers/external/util.go#L285
exported: exported function SetKCPUpdateCompleteAnnotationOnEtcdadmCluster should have comment or be unexported (revive)
|
|
lint:
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go#L71
exported: exported const RegistryUsername should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
controlplane/kubeadm/internal/workload_cluster_etcd.go#L113
exported: exported method Workload.UpdateExternalEtcdEndpointsInKubeadmConfigMap should have comment or be unexported (revive)
|