🌱 Add registryMirrorConfigurations to allowedList in KubeadmControlPlane webhook #83
jiayiwang7Annotations
13 errors and 10 warnings
|
lint (test):
test/infrastructure/docker/internal/docker/machine.go#L212
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint (test):
test/infrastructure/docker/internal/docker/machine.go#L220
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint (test)
issues found
|
|
lint:
cmd/clusterctl/client/move_test.go#L279
cannot use &fakeObjectMover{} (value of type *fakeObjectMover) as "sigs.k8s.io/cluster-api/cmd/clusterctl/client/cluster".ObjectMover value in argument to newFakeCluster(cluster.Kubeconfig{…}, config1).WithProviderInventory(core.Name(), core.Type(), "v1.0.0", "cluster-api-system").WithProviderInventory(infra.Name(), infra.Type(), "v2.0.0", "infra-system").WithObjectMover: *fakeObjectMover does not implement "sigs.k8s.io/cluster-api/cmd/clusterctl/client/cluster".ObjectMover (wrong type for method FromDirectory)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L13
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L9
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/controlplane_join.go#L4
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
bootstrap/kubeadm/types/upstreamv1beta1/conversion.go#L102
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
bootstrap/kubeadm/types/upstreamv1beta3/conversion.go#L90
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
internal/controllers/machine/machine_controller_phases.go#L24
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
internal/controllers/machine/machine_controller_phases.go#L34
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
controlplane/kubeadm/internal/workload_cluster_etcd.go#L20
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
internal/controllers/cluster/cluster_controller_phases.go#L24
File is not `gci`-ed with --skip-generated -s standard,default (gci)
|
|
lint:
util/secret/consts.go#L55
exported: exported const ManagedExternalEtcdCA should have comment (or a comment on this block) or be unexported (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bootstrap.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L25
exported: type name will be used as bottlerocket.BottlerocketConfig by other packages, and that stutters; consider calling this Config (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L44
exported: type name will be used as bottlerocket.BottlerocketSettingsInput by other packages, and that stutters; consider calling this SettingsInput (revive)
|
|
lint:
bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
|
|
lint:
controllers/external/util.go#L248
exported: exported function GetExternalEtcdEndpoints should have comment or be unexported (revive)
|
|
lint:
controllers/external/util.go#L258
exported: exported function IsExternalEtcdUpgrading should have comment or be unexported (revive)
|
|
lint:
controllers/external/util.go#L273
exported: exported function SetKCPUpdateCompleteAnnotationOnEtcdadmCluster should have comment or be unexported (revive)
|
|
lint:
controlplane/kubeadm/internal/workload_cluster_etcd.go#L113
exported: exported method Workload.UpdateExternalEtcdEndpointsInKubeadmConfigMap should have comment or be unexported (revive)
|
|
lint:
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go#L74
exported: exported const RegistryUsername should have comment (or a comment on this block) or be unexported (revive)
|