PR golangci-lint

✨ Add support for in-place upgrades in MachineDeployments #6

Sign in to view logs

Triggered via pull request January 24, 2024 08:03

abhinavmpandey08

opened #29

abhinavmpandey08:in-place-md

Status Failure

Total duration 4m 43s

Artifacts –

pr-golangci-lint.yaml

on: pull_request

Matrix: lint

Annotations

10 errors and 10 warnings

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2296

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2297

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2383

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2420

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2421

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2458

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: internal/controllers/cluster/cluster_controller_test.go#L1000

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: internal/controllers/cluster/cluster_controller_test.go#L1043

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: internal/controllers/cluster/cluster_controller_test.go#L1128

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: internal/controllers/cluster/cluster_controller_test.go#L1175

Error return value of `unstructured.SetNestedField` is not checked (errcheck)

lint: util/secret/consts.go#L55

exported: exported const ManagedExternalEtcdCA should have comment (or a comment on this block) or be unexported (revive)

lint: bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L1

package-comments: package comment should be of the form "Package bottlerocket ..." (revive)

lint: bootstrap/kubeadm/internal/bottlerocket/bootstrap.go#L1

package-comments: package comment should be of the form "Package bottlerocket ..." (revive)

lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L26

exported: type name will be used as bottlerocket.BottlerocketConfig by other packages, and that stutters; consider calling this Config (revive)

lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L45

exported: type name will be used as bottlerocket.BottlerocketSettingsInput by other packages, and that stutters; consider calling this SettingsInput (revive)

lint: controllers/external/util.go#L248

exported: exported function GetExternalEtcdEndpoints should have comment or be unexported (revive)

lint: controllers/external/util.go#L258

exported: exported function IsExternalEtcdUpgrading should have comment or be unexported (revive)

lint: controllers/external/util.go#L273

exported: exported function SetKCPUpdateCompleteAnnotationOnEtcdadmCluster should have comment or be unexported (revive)

lint: bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go#L69

exported: exported const RegistryUsername should have comment (or a comment on this block) or be unexported (revive)

lint: controlplane/kubeadm/internal/workload_cluster_etcd.go#L114

exported: exported method Workload.UpdateExternalEtcdEndpointsInKubeadmConfigMap should have comment or be unexported (revive)