Skip to content

✨ Add new bottlerocket settings for Kubernetes settings support #21

✨ Add new bottlerocket settings for Kubernetes settings support

✨ Add new bottlerocket settings for Kubernetes settings support #21

Re-run triggered June 6, 2024 21:08
Status Failure
Total duration 4m 38s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

10 errors and 13 warnings
lint: internal/controllers/cluster/cluster_controller_test.go#L1000
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: internal/controllers/cluster/cluster_controller_test.go#L1043
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: internal/controllers/cluster/cluster_controller_test.go#L1128
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: internal/controllers/cluster/cluster_controller_test.go#L1175
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2296
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2297
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2383
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2420
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2421
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint: controlplane/kubeadm/internal/controllers/controller_test.go#L2458
Error return value of `unstructured.SetNestedField` is not checked (errcheck)
lint (hack/tools)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe, golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint (test)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe, golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-go@93397bea11091df50f3d7e59dc26a7711a8bcfbe, golangci/golangci-lint-action@3a919529898de77ec3da873e3063ca4b10e7f5cc. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
lint: bootstrap/kubeadm/api/v1beta1/kubeadm_types.go#L236
var-naming: struct field CpuCFSQuota should be CPUCFSQuota (revive)
lint: bootstrap/kubeadm/api/v1beta1/kubeadm_types.go#L239
var-naming: struct field CpuManagerPolicy should be CPUManagerPolicy (revive)
lint: bootstrap/kubeadm/api/v1beta1/kubeadm_types.go#L243
var-naming: struct field CpuManagerPolicyOptions should be CPUManagerPolicyOptions (revive)
lint: bootstrap/kubeadm/api/v1beta1/kubeadm_types.go#L246
var-naming: struct field CpuManagerReconcilePeriod should be CPUManagerReconcilePeriod (revive)
lint: util/secret/consts.go#L55
exported: exported const ManagedExternalEtcdCA should have comment (or a comment on this block) or be unexported (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/controlplane_init.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bootstrap.go#L1
package-comments: package comment should be of the form "Package bottlerocket ..." (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L27
exported: type name will be used as bottlerocket.BottlerocketConfig by other packages, and that stutters; consider calling this Config (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L46
exported: type name will be used as bottlerocket.BottlerocketSettingsInput by other packages, and that stutters; consider calling this SettingsInput (revive)
lint: bootstrap/kubeadm/internal/bottlerocket/bottlerocket.go#L71
var-naming: struct field CpuCFSQuota should be CPUCFSQuota (revive)