Idkwhatimdoing #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abinash18
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Remove The build files, there are those vcxproj files that do not need to be commited to the repo. Those are for your local computer you should include
.vcxproj
.filters
in your gitignore file also ignore everything in the build folder.
Also change the imguiknobs dont edit the file in the imgui knobs module extend that library in the engine rather than editiing the module.
src/InterfaceLayer.cpp
Outdated
toolchain/CMakeCache.txt
Outdated
There was a problem hiding this comment.
Remove everything thats not a source or header file or the changed cmakeconfig but you shouldnt change it without asking me.
|
Just remove the folder modules from being commited. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is right one, imgui update