Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Create token request #1282

Merged
merged 19 commits into from
Apr 18, 2024
Merged

Fix Create token request #1282

merged 19 commits into from
Apr 18, 2024

Conversation

sacOO7
Copy link
Collaborator

@sacOO7 sacOO7 commented Apr 8, 2024 •
edited
Loading

Fixed #1268

@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 8, 2024 16:00 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 12, 2024 12:16 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 15, 2024 11:38 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 15, 2024 12:17 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 16, 2024 10:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 16, 2024 11:45 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 16, 2024 12:18 Inactive
@sacOO7 sacOO7 changed the title Create token request Fix Create token request Apr 16, 2024
@sacOO7 sacOO7 marked this pull request as ready for review April 16, 2024 12:20
@sacOO7 sacOO7 requested a review from ttypic April 16, 2024 12:21
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 16, 2024 12:25 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 16, 2024 18:01 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 17, 2024 08:15 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 08:34 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 10:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 11:28 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 11:43 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 11:51 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 11:54 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 12:02 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 12:10 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 12:16 Inactive
@sacOO7 sacOO7 requested a review from umair-ably April 18, 2024 12:37
ttypic
ttypic approved these changes Apr 18, 2024
View reviewed changes
Copy link

@ttypic ttypic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 17:37 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 17:39 Inactive
@github-actions github-actions bot temporarily deployed to staging/pull/1282/features April 18, 2024 17:42 Inactive
@sacOO7
Copy link
Collaborator Author

sacOO7 commented Apr 18, 2024

Thanks for approval, will merge the PR 👍

@sacOO7 sacOO7 merged commit cb7fb4a into main Apr 18, 2024
7 of 9 checks passed
@sacOO7 sacOO7 deleted the fix/create-token-request branch April 18, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttypic ttypic ttypic approved these changes

@umair-ably umair-ably Awaiting requested review from umair-ably

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.ArgumentException: Can not convert Object to String using CreateTokenRequestObjectAsync()
2 participants
@sacOO7 @ttypic