Skip to content

Commit

Permalink
Added comment on skipped tests describing reason for skipping them
Browse files Browse the repository at this point in the history
  • Loading branch information
sacOO7 committed Jul 5, 2024
1 parent ef7be90 commit e3eb351
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions spec/acceptance/realtime/client_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
context 'and an explicit client_id in ClientOptions' do
let(:client_id) { random_str }

# Skipped because more clarification needed on RSA7e, see https://github.com/ably/ably-ruby/issues/425
xit 'allows uses the explicit client_id in the connection' do
connection.__incoming_protocol_msgbus__.subscribe(:protocol_message) do |protocol_message|
if protocol_message.action == :connected
Expand Down
1 change: 1 addition & 0 deletions spec/acceptance/realtime/connection_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -383,6 +383,7 @@ def publish_and_check_disconnect(options = {})
let(:client_id) { random_str }
let(:client_options) { default_options.merge(client_id: 'incompatible', token: token_string, key: nil, log_level: :none) }

# Skipped because more clarification needed on RSA7e, see https://github.com/ably/ably-ruby/issues/425
xit 'fails the connection' do
expect(client.client_id).to eql('incompatible')
client.connection.once(:failed) do
Expand Down

0 comments on commit e3eb351

Please sign in to comment.