This repository has been archived by the owner on Feb 14, 2023. It is now read-only.
Pause of reading #20
Open
Pause of reading #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abonander @dignifiedquire @xfix Hello, guys. Do you have some time to take a look at this suggestion? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes make it possible to pause/resume reading. It could be useful in case when we are passing a buffer reader forward and are losing control of it, but still, leave the possibility to pause of reading. For example, we have to read huge file and search inside of it. For search, we are using some kind of search and we are passing an instance of a reader into it. Well from that moment we can stop searching only if the searcher supports such kind of functionality, but if it doesn't - we cannot stop searching anyhow. With present changes, we can do it, even if we don't have direct access to the instance of reader.