Update file fingerprint #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the number of ngrams hashed to the file fingerprint Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
JonoYang
commented
May 6, 2024
JonoYang
commented
May 6, 2024
There was a problem hiding this comment.
@pombredanne I have a question about testing the average hamming distance values
* Update .gitignore Signed-off-by: Jono Yang <[email protected]>
* This is to get a better standard deviation
* Refactor common code
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
Signed-off-by: Jono Yang <[email protected]>
JonoYang
force-pushed
the
update-file-fingerprint
branch
from
53bf1e4
to
1a62b18
Compare
Signed-off-by: Jono Yang <[email protected]>
* This is to reduce CI run time Signed-off-by: Jono Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the file fingerprint checksum to also include the number of elements that went into the hash. New tests have been added to profile BitAverageHaloHash behavior