-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCIO-next: Add Almalinux advisories #1491
base: main
Are you sure you want to change the base?
VCIO-next: Add Almalinux advisories #1491
Conversation
Added almalinux advisories and tests for it Signed-off-by: ambuj <[email protected]>
@ziadhany as this importer uses osv.py importer so shall I add AlmaLinux:8 and AlmaLinux:9 in supported ecosystems in osv.py |
@ambuj-1211 yes, you should add it to this |
Signed-off-by: ambuj <[email protected]>
@ambuj-1211
but you will face another issue. you need to add support for almalinux in univers. |
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
@ziadhany can this be merged ? |
I still need to review this code |
…tion - Added a detailed docstring to the `parse_advisory_data` function in the `almalinux-importer` module. - The docstring includes a clear description of the function's purpose, arguments, return value, and an example usage. - Improved the readability and structure of the example output in the docstring to ensure clarity and consistency. This documentation enhancement makes the `parse_advisory_data` function easier to understand and use, aiding future development and maintenance. Signed-off-by: ambuj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use the existing OSV script directly or modify it to support Almalinux, instead of rewriting the entire code?
@ambuj-1211 Update the OSV
|
df053ba
to
088279c
Compare
Signed-off-by: ambuj <[email protected]>
Signed-off-by: ambuj <[email protected]>
@ziadhany please have a look at it I have made the necessary changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @ambuj-1211, the code looks good overall, just a few small nits. Please run the importer and share the logs.
Signed-off-by: ambuj <[email protected]>
almalinux_logs.txt |
Fix #1201
@ziadhany @TG1999 @keshav-space This is the basic nit to adds Alma Linux advisories into vulnerablecode database, please review it to make further changes.