Merge pull request #20819 from abpframework/Session-IpAddresses

Truncate `IpAddresses` of `IdentitySession`.
abpframework · Oct 2, 2024 · 0386df3 · 0386df3
2 parents cdcec59 + 05fd7be
commit 0386df3
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/...s/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/IdentitySessionConsts.cs b/...s/identity/src/Volo.Abp.Identity.Domain.Shared/Volo/Abp/Identity/IdentitySessionConsts.cs
@@ -10,5 +10,5 @@ public class IdentitySessionConsts
 
     public static int MaxClientIdLength { get; set; } = 64;
 
-    public static int MaxIpAddressesLength { get; set; } = 256;
+    public static int MaxIpAddressesLength { get; set; } = 2048;
 }
diff --git a/modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identity/IdentitySession.cs b/modules/identity/src/Volo.Abp.Identity.Domain/Volo/Abp/Identity/IdentitySession.cs
@@ -80,7 +80,22 @@ public IEnumerable<string> GetIpAddresses()
     private static string JoinAsString(IEnumerable<string> list)
     {
         var serialized = string.Join(",", list);
-        return serialized.IsNullOrWhiteSpace() ? null : serialized;
+        if (serialized.IsNullOrWhiteSpace())
+        {
+            return null;
+        }
+
+        while (serialized.Length > IdentitySessionConsts.MaxIpAddressesLength)
+        {
+            var lastCommaIndex = serialized.IndexOf(',');
+            if (lastCommaIndex < 0)
+            {
+                return serialized;
+            }
+            serialized = serialized.Substring(lastCommaIndex + 1);
+        }
+
+        return serialized;
     }
 
     private string[] GetArrayFromString(string str)