Set SendExceptionDataToClientTypes from options.

abpframework · Sep 17, 2024 · bdbe95b · bdbe95b
1 parent 9c1c3a4
commit bdbe95b
Show file tree

Hide file tree

Showing 8 changed files with 20 additions and 8 deletions.
diff --git a/...ponents.Web/Volo/Abp/AspNetCore/Components/Web/ExceptionHandling/UserExceptionInformer.cs b/...ponents.Web/Volo/Abp/AspNetCore/Components/Web/ExceptionHandling/UserExceptionInformer.cs
@@ -67,6 +67,7 @@ protected virtual RemoteServiceErrorInfo GetErrorInfo(UserExceptionInformerConte
         {
             options.SendExceptionsDetailsToClients = Options.SendExceptionsDetailsToClients;
             options.SendStackTraceToClients = Options.SendStackTraceToClients;
+            options.SendExceptionDataToClientTypes = Options.SendExceptionDataToClientTypes;
         });
     }
 }
diff --git a/framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Controllers/ErrorController.cs b/framework/src/Volo.Abp.AspNetCore.Mvc.UI.Theme.Shared/Controllers/ErrorController.cs
@@ -51,6 +51,7 @@ public virtual async Task<IActionResult> Index(int httpStatusCode)
         {
             options.SendExceptionsDetailsToClients = ExceptionHandlingOptions.SendExceptionsDetailsToClients;
             options.SendStackTraceToClients = ExceptionHandlingOptions.SendStackTraceToClients;
+            options.SendExceptionDataToClientTypes = ExceptionHandlingOptions.SendExceptionDataToClientTypes;
         });
 
         if (httpStatusCode == 0)

diff --git a/...c/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ExceptionHandling/AbpExceptionFilter.cs b/...c/Volo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ExceptionHandling/AbpExceptionFilter.cs
@@ -102,6 +102,7 @@ protected virtual void LogException(ExceptionContext context, out RemoteServiceE
         {
             options.SendExceptionsDetailsToClients = exceptionHandlingOptions.SendExceptionsDetailsToClients;
             options.SendStackTraceToClients = exceptionHandlingOptions.SendStackTraceToClients;
+            options.SendExceptionDataToClientTypes = exceptionHandlingOptions.SendExceptionDataToClientTypes;
         });
 
         var remoteServiceErrorInfoBuilder = new StringBuilder();

diff --git a/...lo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ExceptionHandling/AbpExceptionPageFilter.cs b/...lo.Abp.AspNetCore.Mvc/Volo/Abp/AspNetCore/Mvc/ExceptionHandling/AbpExceptionPageFilter.cs
@@ -81,6 +81,7 @@ protected virtual async Task HandleAndWrapException(PageHandlerExecutedContext c
        {
            options.SendExceptionsDetailsToClients = exceptionHandlingOptions.SendExceptionsDetailsToClients;
            options.SendStackTraceToClients = exceptionHandlingOptions.SendStackTraceToClients;
+           options.SendExceptionDataToClientTypes = exceptionHandlingOptions.SendExceptionDataToClientTypes;
        });
 
         var logLevel = context.Exception!.GetLogLevel();

diff --git a/...lo.Abp.AspNetCore/Volo/Abp/AspNetCore/ExceptionHandling/AbpExceptionHandlingMiddleware.cs b/...lo.Abp.AspNetCore/Volo/Abp/AspNetCore/ExceptionHandling/AbpExceptionHandlingMiddleware.cs
@@ -92,6 +92,7 @@ await httpContext.Response.WriteAsync(
                         {
                             options.SendExceptionsDetailsToClients = exceptionHandlingOptions.SendExceptionsDetailsToClients;
                             options.SendStackTraceToClients = exceptionHandlingOptions.SendStackTraceToClients;
+                            options.SendExceptionDataToClientTypes = exceptionHandlingOptions.SendExceptionDataToClientTypes;
                         })
                     )
                 )

diff --git a/...bp.ExceptionHandling/Volo/Abp/AspNetCore/ExceptionHandling/AbpExceptionHandlingOptions.cs b/...bp.ExceptionHandling/Volo/Abp/AspNetCore/ExceptionHandling/AbpExceptionHandlingOptions.cs
@@ -5,9 +5,19 @@ namespace Volo.Abp.AspNetCore.ExceptionHandling;
 
 public class AbpExceptionHandlingOptions
 {
-    public bool SendExceptionsDetailsToClients { get; set; } = false;
+    public bool SendExceptionsDetailsToClients { get; set; }
 
-    public bool SendStackTraceToClients { get; set; } = true;
+    public bool SendStackTraceToClients { get; set; }
 
-    public List<Type> SendExceptionDataToClientTypes { get; } = new List<Type>();
+    public List<Type> SendExceptionDataToClientTypes { get; set; }
+
+    public AbpExceptionHandlingOptions()
+    {
+        SendExceptionsDetailsToClients = false;
+        SendStackTraceToClients = true;
+        SendExceptionDataToClientTypes =
+        [
+            typeof(IBusinessException)
+        ];
+    }
 }
diff --git a/...ionHandling/Volo/Abp/AspNetCore/ExceptionHandling/DefaultExceptionToErrorInfoConverter.cs b/...ionHandling/Volo/Abp/AspNetCore/ExceptionHandling/DefaultExceptionToErrorInfoConverter.cs
@@ -329,11 +329,7 @@ protected virtual AbpExceptionHandlingOptions CreateDefaultOptions()
         return new AbpExceptionHandlingOptions
         {
             SendExceptionsDetailsToClients = false,
-            SendStackTraceToClients = true,
-            SendExceptionDataToClientTypes =
-            {
-                typeof(IBusinessException)
-            }
+            SendStackTraceToClients = true
         };
     }
 }
diff --git a/...src/Volo.Abp.AuditLogging.Domain/Volo/Abp/AuditLogging/AuditLogInfoToAuditLogConverter.cs b/...src/Volo.Abp.AuditLogging.Domain/Volo/Abp/AuditLogging/AuditLogInfoToAuditLogConverter.cs
@@ -57,6 +57,7 @@ public virtual Task<AuditLog> ConvertAsync(AuditLogInfo auditLogInfo)
                                           {
                                               options.SendExceptionsDetailsToClients = ExceptionHandlingOptions.SendExceptionsDetailsToClients;
                                               options.SendStackTraceToClients = ExceptionHandlingOptions.SendStackTraceToClients;
+                                              options.SendExceptionDataToClientTypes = ExceptionHandlingOptions.SendExceptionDataToClientTypes;
                                           }))
                                       ?? new List<RemoteServiceErrorInfo>();