Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GetUserNameFromEmailAsync to IdentityUserManager. #18612

Merged
merged 6 commits into from
Jan 2, 2024

Conversation

maliming
Copy link
Member

No description provided.

@maliming maliming added this to the 8.0-patch milestone Dec 27, 2023
@maliming maliming marked this pull request as ready for review December 28, 2023 02:32
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (b9a6bff) 51.61% compared to head (3a23269) 51.60%.
Report is 50 commits behind head on rel-8.0.

Files Patch % Lines
...sts/Volo/Abp/Identity/IdentityUserManager_Tests.cs 0.00% 61 Missing ⚠️
...ty.Domain/Volo/Abp/Identity/IdentityUserManager.cs 75.00% 13 Missing and 9 partials ⚠️
...ing/Templates/RandomizeAuthServerPassPhraseStep.cs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           rel-8.0   #18612      +/-   ##
===========================================
- Coverage    51.61%   51.60%   -0.02%     
===========================================
  Files         3074     3074              
  Lines        96942    97091     +149     
  Branches      7712     7729      +17     
===========================================
+ Hits         50040    50106      +66     
- Misses       45370    45444      +74     
- Partials      1532     1541       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliming maliming changed the title Add ValidateUserNameAsync & GetRandomUserNameAsync to IdentityUserManager. Add GetUserNameFromEmailAsync to IdentityUserManager. Dec 28, 2023
@salihozkara salihozkara merged commit e54bb8a into rel-8.0 Jan 2, 2024
3 of 5 checks passed
@salihozkara salihozkara deleted the AllowedUserNameCharacters branch January 2, 2024 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants