reafctor: remove readers implementation

Signed-off-by: Felix Gateru <[email protected]>
absmach · Jan 9, 2025 · 7402e2b · 7402e2b
1 parent 2b2d8b8
commit 7402e2b
Show file tree

Hide file tree

Showing 37 changed files with 7 additions and 5,328 deletions.
diff --git a/.github/workflows/api-tests.yml b/.github/workflows/api-tests.yml
@@ -22,7 +22,6 @@ on:
       - "invitations/api/**"
       - "journal/api/**"
       - "provision/api/**"
-      - "readers/api/**"
       - "users/api/**"
 
 env:
@@ -42,8 +41,6 @@ env:
   BOOTSTRAP_URL: http://localhost:9013
   CERTS_URL: http://localhost:9019
   PROVISION_URL: http://localhost:9016
-  POSTGRES_READER_URL: http://localhost:9009
-  TIMESCALE_READER_URL: http://localhost:9011
   JOURNAL_URL: http://localhost:9021
 
 jobs:
@@ -118,11 +115,6 @@ jobs:
               - "apidocs/openapi/provision.yml"
               - "provision/api/**"
 
-            readers:
-              - ".github/workflows/api-tests.yml"
-              - "apidocs/openapi/readers.yml"
-              - "readers/api/**"
-
             clients:
               - ".github/workflows/api-tests.yml"
               - "apidocs/openapi/clients.yml"
@@ -263,32 +255,6 @@ jobs:
           report: false
           args: '--header "Authorization: Bearer ${{ env.USER_TOKEN }}" --contrib-openapi-formats-uuid --hypothesis-suppress-health-check=filter_too_much --stateful=links'
 
-      - name: Seed Messages
-        if: steps.changes.outputs.readers == 'true'
-        run: |
-          make cli
-          ./build/cli provision test
-
-      - name: Run Postgres Reader API tests
-        if: steps.changes.outputs.readers == 'true'
-        uses: schemathesis/action@v1
-        with:
-          schema: apidocs/openapi/readers.yml
-          base-url: ${{ env.POSTGRES_READER_URL }}
-          checks: all
-          report: false
-          args: '--header "Authorization: Bearer ${{ env.USER_TOKEN }}" --contrib-openapi-formats-uuid --hypothesis-suppress-health-check=filter_too_much --stateful=links'
-
-      - name: Run Timescale Reader API tests
-        if: steps.changes.outputs.readers == 'true'
-        uses: schemathesis/action@v1
-        with:
-          schema: apidocs/openapi/readers.yml
-          base-url: ${{ env.TIMESCALE_READER_URL }}
-          checks: all
-          report: false
-          args: '--header "Authorization: Bearer ${{ env.USER_TOKEN }}" --contrib-openapi-formats-uuid --hypothesis-suppress-health-check=filter_too_much --stateful=links'
-
       - name: Stop containers
         if: always()
         run: make run down args="-v" && make run_addons down args="-v"
diff --git a/.github/workflows/check-generated-files.yml b/.github/workflows/check-generated-files.yml
@@ -65,7 +65,6 @@ jobs:
               - "users/emailer.go"
               - "users/hasher.go"
               - "mqtt/events/streams.go"
-              - "readers/messages.go"
               - "consumers/notifiers/notifier.go"
               - "consumers/notifiers/service.go"
               - "consumers/notifiers/subscriptions.go"

diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -243,7 +243,6 @@ jobs:
               - "internal/groups/**"
               - "invitations/**"
               - "provision/**"
-              - "readers/**"
               - "clients/**"
               - "users/**"
 
@@ -262,15 +261,6 @@ jobs:
               - "logger/**"
               - "pkg/sdk/**"
 
-            readers:
-              - "readers/**"
-              - "cmd/postgres-reader/**"
-              - "cmd/timescale-reader/**"
-              - "auth.pb.go"
-              - "auth_grpc.pb.go"
-              - "clients/**"
-              - "auth/**"
-
             users:
               - "users/**"
               - "cmd/users/**"
@@ -403,11 +393,6 @@ jobs:
         run: |
           go test --race -v -count=1 -coverprofile=coverage/provision.out ./provision/...
 
-      - name: Run readers tests
-        if: steps.changes.outputs.readers == 'true' || steps.changes.outputs.workflow == 'true'
-        run: |
-          go test --race -v -count=1 -coverprofile=coverage/readers.out ./readers/...
-
       - name: Run clients tests
         if: steps.changes.outputs.clients == 'true' || steps.changes.outputs.workflow == 'true'
         run: |

diff --git a/Makefile b/Makefile
@@ -3,9 +3,9 @@
 
 SMQ_DOCKER_IMAGE_NAME_PREFIX ?= supermq
 BUILD_DIR ?= build
-SERVICES = auth users clients groups channels domains http coap ws postgres-writer postgres-reader timescale-writer \
-	timescale-reader cli bootstrap mqtt provision certs invitations journal
-TEST_API_SERVICES = journal auth bootstrap certs http invitations notifiers provision readers clients users channels groups domains
+SERVICES = auth users clients groups channels domains http coap ws postgres-writer timescale-writer \
+	cli bootstrap mqtt provision certs invitations journal
+TEST_API_SERVICES = journal auth bootstrap certs http invitations notifiers provision clients users channels groups domains
 TEST_API = $(addprefix test_api_,$(TEST_API_SERVICES))
 DOCKERS = $(addprefix docker_,$(SERVICES))
 DOCKERS_DEV = $(addprefix docker_dev_,$(SERVICES))
@@ -73,7 +73,7 @@ define make_docker_dev
 		-f docker/Dockerfile.dev ./build
 endef
 
-ADDON_SERVICES = bootstrap journal provision certs timescale-reader timescale-writer postgres-reader postgres-writer
+ADDON_SERVICES = bootstrap journal provision certs timescale-writer postgres-writer
 
 EXTERNAL_SERVICES = vault prometheus
 
@@ -178,7 +178,6 @@ test_api_auth: TEST_API_URL := http://localhost:9001
 test_api_bootstrap: TEST_API_URL := http://localhost:9013
 test_api_certs: TEST_API_URL := http://localhost:9019
 test_api_provision: TEST_API_URL := http://localhost:9016
-test_api_readers: TEST_API_URL := http://localhost:9009 # This can be the URL of any reader service.
 test_api_journal: TEST_API_URL := http://localhost:9021
 
 $(TEST_API):