SMQ-2568 - Check Domain enabled / disabled status during Authn or Authz #2586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
noissue-check-domain
branch
from
ff186ad to
4da52f1
Compare
arvindh123
requested changes
Dec 15, 2024
dborovcanin
force-pushed
the
noissue-check-domain
branch
from
4da52f1 to
4b3b4bd
Compare
felixgateru
force-pushed
the
noissue-check-domain
branch
3 times, most recently
from
accffa1 to
5b5ef9b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2586 +/- ##
==========================================
+ Coverage 45.67% 46.76% +1.09%
==========================================
Files 398 156 -242
Lines 50091 23988 -26103
==========================================
- Hits 22879 11218 -11661
+ Misses 24854 11806 -13048
+ Partials 2358 964 -1394 ☔ View full report in Codecov by Sentry. |
arvindh123
requested changes
Dec 17, 2024
arvindh123
requested changes
Dec 18, 2024
arvindh123
requested changes
Dec 18, 2024
felixgateru
force-pushed
the
noissue-check-domain
branch
3 times, most recently
from
0f23321 to
3fa5055
Compare
arvindh123
requested changes
Dec 20, 2024
pkg/authz/authz.go
Outdated
Comment on lines
6
to
8
| import ( | ||
| "context" | ||
| ) |
felixgateru
force-pushed
the
noissue-check-domain
branch
2 times, most recently
from
9c88d26 to
c4e4a5c
Compare
arvindh123
approved these changes
Dec 23, 2024
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
force-pushed
the
noissue-check-domain
branch
from
c4e4a5c to
86d3787
Compare
dborovcanin
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a feature as it adds check domain authorization for domain related operations by users.
What does this do?
This pr adds domain check authorization to existing authorization. The check domain is meant to ensure only domain admins can access a disabled domain and only super admins can access a frozen domain.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Yes, tests have been added.
Did you document any new/modified feature?
No
Notes
None