-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Use role id instead of name #2612
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2612 +/- ##
==========================================
- Coverage 45.43% 42.25% -3.19%
==========================================
Files 404 202 -202
Lines 50450 30093 -20357
==========================================
- Hits 22921 12715 -10206
+ Misses 25170 16411 -8759
+ Partials 2359 967 -1392 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to update the api docs for this change
This PR is depend on #2585 |
aa834d4
to
6c8bee9
Compare
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
6c8bee9
to
2e14564
Compare
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
What type of PR is this?
This is a feature because it adds the following functionality:
Change from Role Name to Role ID
What does this do?
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
Did you document any new/modified feature?
Notes