Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NOISSUE - Emit roles event during entity creation #2620

Merged
merged 7 commits into from
Dec 27, 2024

Conversation

arvindh123
Copy link
Contributor

What type of PR is this?

What does this do?

Which issue(s) does this PR fix/relate to?

  • Related Issue #
  • Resolves #

Have you included tests for your changes?

Did you document any new/modified feature?

Notes

@arvindh123 arvindh123 marked this pull request as draft December 25, 2024 09:13
@arvindh123 arvindh123 self-assigned this Dec 25, 2024
@arvindh123 arvindh123 force-pushed the return_role_provision branch from cf999bc to d31ef14 Compare December 25, 2024 13:29
@arvindh123 arvindh123 changed the title NOISSUE : Emit roles event during entity certation NOISSUE - Emit roles event during entity certation Dec 25, 2024
@arvindh123 arvindh123 force-pushed the return_role_provision branch from a1df649 to 5ba08d8 Compare December 26, 2024 10:19
@arvindh123 arvindh123 force-pushed the return_role_provision branch from 5ba08d8 to 094827a Compare December 26, 2024 10:28
@arvindh123 arvindh123 marked this pull request as ready for review December 26, 2024 12:44
@arvindh123 arvindh123 force-pushed the return_role_provision branch from eb05078 to a48a983 Compare December 26, 2024 13:31
Signed-off-by: Arvindh <[email protected]>
Signed-off-by: Arvindh <[email protected]>
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

Attention: Patch coverage is 37.57576% with 103 lines in your changes missing coverage. Please review.

Project coverage is 42.26%. Comparing base (c32d406) to head (2203b60).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
channels/mocks/service.go 47.36% 6 Missing and 4 partials ⚠️
clients/mocks/service.go 47.36% 6 Missing and 4 partials ⚠️
groups/mocks/service.go 47.36% 6 Missing and 4 partials ⚠️
channels/events/streams.go 0.00% 7 Missing ⚠️
clients/events/streams.go 0.00% 7 Missing ⚠️
groups/events/streams.go 0.00% 7 Missing ⚠️
channels/events/events.go 0.00% 5 Missing ⚠️
channels/mocks/repository.go 0.00% 5 Missing ⚠️
clients/events/events.go 0.00% 5 Missing ⚠️
clients/mocks/repository.go 0.00% 5 Missing ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2620      +/-   ##
==========================================
- Coverage   45.44%   42.26%   -3.19%     
==========================================
  Files         404      202     -202     
  Lines       50448    30123   -20325     
==========================================
- Hits        22924    12730   -10194     
+ Misses      25163    16420    -8743     
+ Partials     2361      973    -1388     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dborovcanin dborovcanin changed the title NOISSUE - Emit roles event during entity certation NOISSUE - Emit roles event during entity creation Dec 27, 2024
@dborovcanin dborovcanin merged commit f12aacd into absmach:main Dec 27, 2024
6 of 9 checks passed
@dborovcanin dborovcanin deleted the return_role_provision branch December 27, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants