SMQ-2629 - Remove Boostrap and Provision services #2640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixgateru
force-pushed
the
smq2629-bootstrap
branch
from
92ac771 to
5f5930f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2640 +/- ##
==========================================
- Coverage 45.41% 40.33% -5.09%
==========================================
Files 404 347 -57
Lines 50517 42674 -7843
==========================================
- Hits 22941 17211 -5730
+ Misses 25207 24194 -1013
+ Partials 2369 1269 -1100 ☔ View full report in Codecov by Sentry. |
felixgateru
force-pushed
the
smq2629-bootstrap
branch
from
5f5930f to
c51c705
Compare
dborovcanin
changed the title
dborovcanin
requested changes
Jan 9, 2025
dborovcanin
force-pushed
the
smq2629-bootstrap
branch
from
c51c705 to
6c29f51
Compare
dborovcanin
requested changes
Jan 10, 2025
| @@ -381,48 +381,6 @@ SMQ_WS_ADAPTER_HTTP_SERVER_KEY= | |||
| SMQ_WS_ADAPTER_INSTANCE_ID= | |||
|
|
|||
| ## Addons Services | |||
| ### Bootstrap | |||
There was a problem hiding this comment.
Remove L179 SMQ_BOOTSTRAP_URL=http://bootstrap:9013 from the UI section (we will remove the whole UI or replace it soon).
felixgateru
force-pushed
the
smq2629-bootstrap
branch
from
6c29f51 to
40b10d3
Compare
dborovcanin
approved these changes
Jan 10, 2025
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
Signed-off-by: Felix Gateru <[email protected]>
dborovcanin
force-pushed
the
smq2629-bootstrap
branch
from
40b10d3 to
cac4413
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
This is a refactor as it removes the bootsrap and provision services.
What does this do?
This pr removes the bootstrap and provision services from supermq.
Which issue(s) does this PR fix/relate to?
Have you included tests for your changes?
No
Did you document any new/modified feature?
No
Notes
None