Fixed the determination of the entity class name (for proxied classes) used as key in $cachedDecryptions #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es) used as key in $cachedDecryptions - Update coding to follow best practices - Removed unnecessary !is_null check where !empty() is in use - Replaced -5 with -strlen(self::ENCRYPTION_MARKER)
…es) used as key in $cachedDecryptions - Update coding to follow best practices - Removed unnecessary !is_null check where !empty() is in use - Replaced -5 with -strlen(self::ENCRYPTION_MARKER)
…es) used as key in $cachedDecryptions - Update coding to follow best practices - Removed unnecessary !is_null check where !empty() is in use - Replaced -5 with -strlen(self::ENCRYPTION_MARKER)
|
Seems some of these changes are already part of: https://github.com/DoctrineEncryptBundle/DoctrineEncryptBundle Please see these comments:
The new package that I hope will be maintained by more than 1 person |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the determination of the entity class name (for proxied classes) used as key in $cachedDecryptions
Before the fix, entities were sometimes decrypted and encrypted several times in certain situations, even though only read operations took place. This led to unnecessary write operations and thus to incorrect date changes (last_changed) if such an attribute exists in the data model.
Changed coding in some places to follow best practices
Removed unnecessary !is_null() check where !empty() was in use too
Replaced -5 with -strlen(self::ENCRYPTION_MARKER)