Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs and logo #14

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs and logo #14

wants to merge 1 commit into from

Conversation

arpanda
Copy link
Member

@arpanda arpanda commented Apr 14, 2022

Purpose/implementation Section

What changes are being implemented in this Pull Request?

What was your approach?

What GitHub issue does your pull request address?

Tell potential reviewers what kind of feedback you are soliciting.

New Content Checklist

@github-actions
Copy link

No broken URLs detected! 🎉
Comment updated at 2022-04-14 with changes from 8819f0b

@github-actions
Copy link

No spelling errors! 🎉
Comment updated at 2022-04-14 with changes from 8819f0b

@github-actions
Copy link

Re-rendered previews from the latest commit:

Updated at 2022-04-14 with changes from 8819f0b

@arpanda
Copy link
Member Author

arpanda commented Apr 14, 2022

@cansavvy The preview is not aligning with the current page. is there any issue?

@cansavvy
Copy link
Collaborator

@cansavvy The preview is not aligning with the current page. is there any issue?

That is by design. This preview shows you what this particular branch's changes look like, whereas the GitHub pages is publishing from the main branch.

Basically this preview allows you to get an idea of what your changes look like before you make them live by merging to main.

Thanks for this comment, I'll make sure to have the guide explain this concept better!

@cansavvy
Copy link
Collaborator

@arpanda, does this make sense? If not, would you be able to let me know what part doesn't make sense? Your feedback is helpful for me making sure our OTTR instructions are more clear.

That is by design. This preview shows you what this particular branch's changes look like, whereas the GitHub pages is publishing from the main branch.

Basically this preview allows you to get an idea of what your changes look like before you make them live by merging to main.

@arpanda
Copy link
Member Author

arpanda commented Apr 20, 2022

Sorry for my delayed response. Thanks @cansavvy .
Yes. The logic is very clear to me and the preview depends on the dev branch only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants