-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alterações feitas pelo WillHubner com algumas correções #60
base: master
Are you sure you want to change the base?
Conversation
for prpRtti in typRtti.GetProperties do | ||
begin | ||
if not prpRtti.IsIgnore then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aqui o IsIgnore deixa de existir.
aSQL := aSQL + ' order by ' + aPK + ' desc'; | ||
|
||
case FSQLType of | ||
Firebird: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ainda acho que poderia ter uma implementação para cada SqlType, mas resolve bem as issues,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Muito bacana, vou testar logo mais.
Algumas coisas poderiam ser diferentes, mas de uma forma geral eu gostei bastante.
Acho que o único problema é o de remover a lógica do "IsIgnore".
Essa PR tem todas as alterações feitas pelo WillHubner, só precisei incluir a configuração de tipo de SQL em algumas funções de busca do SimpleDAO.
Segue a lista de commits feito pelo WillHubner: