Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alterações feitas pelo WillHubner com algumas correções #60

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

soft-clever
Copy link

Essa PR tem todas as alterações feitas pelo WillHubner, só precisei incluir a configuração de tipo de SQL em algumas funções de busca do SimpleDAO.

Segue a lista de commits feito pelo WillHubner:

for prpRtti in typRtti.GetProperties do
begin
if not prpRtti.IsIgnore then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aqui o IsIgnore deixa de existir.

aSQL := aSQL + ' order by ' + aPK + ' desc';

case FSQLType of
Firebird:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ainda acho que poderia ter uma implementação para cada SqlType, mas resolve bem as issues,

Copy link
Contributor

@reinaldoacdc reinaldoacdc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bacana, vou testar logo mais.
Algumas coisas poderiam ser diferentes, mas de uma forma geral eu gostei bastante.

Acho que o único problema é o de remover a lógica do "IsIgnore".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants