Draft: xdp: checksum optimization #22
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let's apply the optimization from the RFC1141 since we do not need to recompute the checksum for each ttl-- Warning: I am still trying to run a virtual lab environment, so this commit is untested.
Let's save some more cycles if it is not already done by the compiler.
|
saddr & daddr are also altered |
arch, I did miss it, it was a bit late ! Right, this pull request will break it. Thanks @acassen for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's apply the optimization from the RFC1141 since we do not need to recompute the checksum for each ttl--
Warning: I am still trying to run a virtual lab environment, so this commit is untested.
I'd like to keep this pull request "opened" until it'll be fully tested. Currently, it is just based on proof reading.