class-declaration-abstractness-changed #974
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,11 +54,17 @@ const classDeclarationTypeChanged: ComparerFactory = (context) => ({ | |||
| if (aType === bType) { | |||
| return; | |||
| } | |||
| context.report({ | |||
There was a problem hiding this comment.
The existing type-change report shouldn't be removed. Instead, the if statement above should be inverted (aType !== bType or whatever) and the report should be put in there.
| const changeSeverity = isAbstract(a) ? 'minor' : 'major'; | ||
| context.report({ | ||
| key: 'class-declaration-abstractness-changed', | ||
| message: `The class "${a.getName()}" changed from ${changeType} (${changeSeverity} change).`, |
There was a problem hiding this comment.
The severity can't simply be expressed in the message but must be defined here:
You'll need to create two different keys: one for abstract to concrete, and one for concrete to abstract.
There was a problem hiding this comment.
I have added the rules, and change the severity to changeKey.
The pull request is ready for review.
please let me know if any changes need.
|
It looks okay to me, but I'm not part of the Concerto team so they'll have to review it. I expect they would like to see a test, for example. I think you can search for the other result codes (keys) and find where the existing tests are. |
|
Thanks for the suggestion! I’ll look into searching for the result codes
and check the existing tests.
…On Sun, Dec 22, 2024, 11:31 PM DS-AdamMilazzo ***@***.***> wrote:
It looks okay to me, but I'm not part of the Concerto team so they'll have
to review it. I expect they would like to see a test, for example. I think
you can search for the other result codes (keys) and find where the
existing tests are.
—
Reply to this email directly, view it on GitHub
<#974 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BKJ2ERKOFVNQBUFEJAXYV3D2G35A5AVCNFSM6AAAAABUAZFFHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGUZTSNJSHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Hi AdamMilazzo,
I hope you're doing well! I’m really interested in contributing to the
Accord project, especially for GSoC 2025. I’ve started exploring the
codebase and would love to begin contributing by fixing bugs or adding
small features. Could you recommend any tasks or open issues that I can
start with?
I’d also appreciate any advice on how to get more involved early on. How
can I connect with you or other mentors to discuss potential project ideas
for next year? Additionally, how can I find the listed projects for the
Accord organization for GSoC 2025?
Also, I was wondering how I can connect with Accord members in the forums
or other community channels. Any tips on how to get in touch with other
contributors or mentors there would be great!
Thank you for your time and support! Looking forward to hearing from you.
Best regards,
B Mamatha
***@***.***
On Mon, Dec 23, 2024, 12:08 AM Mamatha Bandi ***@***.***>
wrote:
… Thanks for the suggestion! I’ll look into searching for the result codes
and check the existing tests.
On Sun, Dec 22, 2024, 11:31 PM DS-AdamMilazzo ***@***.***>
wrote:
> It looks okay to me, but I'm not part of the Concerto team so they'll
> have to review it. I expect they would like to see a test, for example. I
> think you can search for the other result codes (keys) and find where the
> existing tests are.
>
> —
> Reply to this email directly, view it on GitHub
> <#974 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/BKJ2ERKOFVNQBUFEJAXYV3D2G35A5AVCNFSM6AAAAABUAZFFHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJYGUZTSNJSHE>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Changes
Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname