Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(*): remove unused deps and update concerto deps #631

Merged
merged 10 commits into from
Dec 2, 2024

Conversation

muhabdulkadir
Copy link
Contributor

@muhabdulkadir muhabdulkadir commented Nov 29, 2024

Closes #

Changes

  • remove unused deps and update concerto deps

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@coveralls
Copy link

coveralls commented Nov 29, 2024

Pull Request Test Coverage Report for Build 12113143735

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.929%

Totals Coverage Status
Change from base Build 12087009059: 0.0%
Covered Lines: 2776
Relevant Lines: 3791

💛 - Coveralls

@muhabdulkadir muhabdulkadir reopened this Nov 29, 2024
@muhabdulkadir muhabdulkadir force-pushed the main branch 4 times, most recently from 506fd6d to 5f8d31b Compare December 2, 2024 03:11
Signed-off-by: muhammed-abdulkadir <[email protected]>
muhammed-abdulkadir added 5 commits December 2, 2024 07:20
Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
@sanketshevkar
Copy link
Member

sanketshevkar commented Dec 2, 2024

Also, the build/publish to npm step is failing in the main pipeline for last 3 code merges. Is that a known issue being parked for later?

@muhabdulkadir
Copy link
Contributor Author

Also, the build/publish to npm step is failing in the main pipeline for last 3 code merges. Is that a known issue being parked for later?

This is a known issue.

Signed-off-by: muhammed-abdulkadir <[email protected]>
Signed-off-by: muhammed-abdulkadir <[email protected]>
@sanketshevkar sanketshevkar merged commit 92f912f into accordproject:main Dec 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants