fix(relations): fix modal overflow to access dropdown #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reverted modal dialog overflow to `visible` in the new relations form so that when the dialog height is shorter than the dropdown, the dropdown remains accessible without having to scroll the dialog. introduced max-height and auto scroll option for `#relation-dialog-content` so that when the contents of the dialog overflows the dialog height, the dialog is scrollable (maintains the behaviour of fix #1351) closes #1359
gythaogg
deleted the
gythaogg/1359-new-relation-show-autocomplete-dropdown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reverted modal dialog overflow to
visiblein the new relations form so that when the dialog height is shorter than the dropdown, the dropdown remains accessible without having to scroll the dialog.introduced max-height and auto scroll option for
#relation-dialog-contentso that when the contents of the dialog overflows the dialog height, the dialog is scrollable (maintains the behaviour of fix #1351)closes #1359