fix: replace custom duplication logic with signal #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b1rger
force-pushed
the
birger/implement-duplicate-for-relations
branch
2 times, most recently
from
f5c94e3
to
6ea6ab3
Compare
sennierer
reviewed
Aug 29, 2023
apis_core/apis_relations/models.py
Outdated
| self._state.adding = True | ||
| duplicate = self.save() | ||
|
|
||
| instance = origin.objects.get(pk=oldid) |
There was a problem hiding this comment.
wouldnt it be cheaper (database calls wise) to deep copy self before setting pk and id to None and using that as instance? instead of loading it again from the db? because I guess instance == self [pre line 320]
sennierer
approved these changes
Aug 29, 2023
For duplicating entities, there was custom logic to copy ManyToManyField - which was tailored to TempTriples. This had the downside of simply creating new objects by hand. This commit introduces a `duplicate` method in the Triple model, which implements the functionality of duplicating itself and also triggers pre_- and post_duplicate signals. This has the advantage that instances that point to the Triple (like References) can also be duplicated using signals.
b1rger
force-pushed
the
birger/implement-duplicate-for-relations
branch
from
6ea6ab3
to
540dca9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For duplicating entities, there was custom logic to copy ManyToManyField
creating new objects by hand.
This commit introduces a
duplicatemethod in the Triple model, whichimplements the functionality of duplicating itself and also triggers
pre_- and post_duplicate signals. This has the advantage that instances
that point to the Triple (like References) can also be duplicated using
signals.