feat(history): adds tests for history plugin #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sennierer
force-pushed
the
ms/add-tests-for-history
branch
from
4a09e9c
to
282d92c
Compare
b1rger
requested changes
May 13, 2024
sennierer
force-pushed
the
ms/add-tests-for-history
branch
from
282d92c
to
742bb1b
Compare
is moved |
|
This should now be updated for the |
|
ping |
sennierer
force-pushed
the
ms/add-tests-for-history
branch
from
742bb1b
to
bc64801
Compare
|
adapted the existing tests to the sample project. presumably the check in line 11 (for the CI env variable) can be removed as the tests should now run in CI as well. However, i suggest to merge these simple tests first and lift the check for CI in another PR |
sennierer
force-pushed
the
ms/add-tests-for-history
branch
from
bc64801
to
d2d84e3
Compare
b1rger
requested changes
Aug 20, 2024
sennierer
force-pushed
the
ms/add-tests-for-history
branch
from
d2d84e3
to
2c258c4
Compare
|
good point, changed that |
b1rger
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently tests for the history plugin lack an ontology for running. This is a draft PR until we added an ontology to the testing env.