Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ÖBL JS for map, fix problems with code #842

Closed
wants to merge 1 commit into from

Conversation

koeaw
Copy link
Contributor

@koeaw koeaw commented May 15, 2024

No description provided.

@koeaw koeaw force-pushed the kk/feat/javascript_for_map branch from 2b223fb to a642379 Compare May 15, 2024 07:09
@koeaw koeaw linked an issue May 15, 2024 that may be closed by this pull request
@koeaw koeaw requested a review from b1rger May 15, 2024 07:11
Copy link
Contributor

@b1rger b1rger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits, no need to commit buggy code and then commit two fixes on top.
can we get rid of the use of jquery?

I think it would make sense to move the javascript part to a separate .js file

@koeaw
Copy link
Contributor Author

koeaw commented May 15, 2024

can we get rid of the use of jquery?

All in favour of this suggestion in general, but would postpone it to a follow-up issue.

I think it would make sense to move the javascript part to a separate .js file

Yes, I was actually going to ask if we could please clean up the chaos in some of the templates by dealing with JS and CSS separately (may have mentioned this somewhere before).

@koeaw koeaw force-pushed the kk/feat/javascript_for_map branch from a642379 to 4a86a69 Compare May 15, 2024 09:29
Add JavaScript and styling for map preview
of where places with longitude and latitude
datapoints are located.

Co-authored-by: KK <[email protected]>

Closes: #639
@koeaw koeaw force-pushed the kk/feat/javascript_for_map branch from 4a86a69 to f6e84ac Compare May 15, 2024 09:33
@koeaw
Copy link
Contributor Author

koeaw commented May 15, 2024

@b1rger Commits squashed down into one.

@sennierer
Copy link
Collaborator

Include changes made in pfp-oebl repo in this fix

@b1rger
Copy link
Contributor

b1rger commented Aug 13, 2024

ping

@b1rger
Copy link
Contributor

b1rger commented Sep 18, 2024

superseded by #1192

@b1rger b1rger closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include map visualization javascript
3 participants