Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TimespanMixins #91

Merged
merged 1 commit into from
Sep 7, 2023
Merged

Introduce TimespanMixins #91

merged 1 commit into from
Sep 7, 2023

Conversation

b1rger
Copy link
Contributor

@b1rger b1rger commented Mar 13, 2023

This commit introduces a LegacyDateMixin that provides commonly used
fields for models that need a temporal component. This is based on
relations and entities as they were used in APIS until now.

Closes: #66

@b1rger b1rger force-pushed the birger/66-datemixin branch 2 times, most recently from 377d608 to 461f373 Compare March 13, 2023 09:54
@SteffRhes
Copy link
Member

Isn't Gregor already working on such?

@b1rger
Copy link
Contributor Author

b1rger commented Mar 13, 2023

Isn't Gregor already working on such?

Our minutes say:

Start with a date mixin
...
-> Birger to come up with a PR

@SteffRhes
Copy link
Member

lol, sorry for overlooking this, had it wrong in memory.

@SteffRhes
Copy link
Member

Just wanted to be sure to avoid duplicated effort.

@b1rger b1rger force-pushed the birger/66-datemixin branch 2 times, most recently from 00be1fe to 7f30162 Compare August 28, 2023 11:11
This commit introduces a LegacyDateMixin that provides commonly used
fields for models that need a temporal component. This is based on
relations and entities as they were used in APIS until now.

Closes: #66
@b1rger b1rger marked this pull request as ready for review August 28, 2023 11:15
@b1rger b1rger requested a review from a team August 28, 2023 11:16
@b1rger b1rger merged commit fe3c205 into main Sep 7, 2023
6 checks passed
@b1rger b1rger deleted the birger/66-datemixin branch September 8, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a DateMixin
2 participants