Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter doesn't adapt cities list when selecting a country #76

Closed
patrickakk opened this issue Jun 7, 2023 · 5 comments
Closed

Filter doesn't adapt cities list when selecting a country #76

patrickakk opened this issue Jun 7, 2023 · 5 comments
Labels
bug Something isn't working - Kind of issue frontend Front End - Part of application specsmissing Development can’t start because specifications are missing – Status of issue

Comments

@patrickakk
Copy link
Contributor

This issue was addressed in the WG meeting at 2023-06-06.

When using the filter, selecting a country and immediately selecting a city, the list of cities contains all countries. The list is expected to be updated and contain only the cities in the selected country.
(The filter works fine).

Different behavior:
In the filter: when selecting a country, selecting a city (which is not in the country) and selecting another city, the second time, the cities list contains only the cities in the selected country.

So it looks like the updating of cities list fails at a point.

Proposed solution:
See if this can be fixed in a small amount of time. If possible, fix immediately. So assigned to July milestone.
If it turns out to be more complex; remove from July milestone and find time in the future.

@patrickakk patrickakk added bug Something isn't working - Kind of issue frontend Front End - Part of application todo Ready to start development - Status of issue labels Jun 7, 2023
@patrickakk patrickakk added this to the July 2023 milestone Jun 7, 2023
@patrickakk patrickakk self-assigned this Jun 7, 2023
@patrickakk patrickakk added specsmissing Development can’t start because specifications are missing – Status of issue and removed todo Ready to start development - Status of issue labels Jun 15, 2023
@patrickakk
Copy link
Contributor Author

This also applies for example to institutions. When selecting a country, you can also select institutions outside this country. It seems that the current sub-window with the filter options was designed in a way that the user has to close it (cross in right top corner) to apply the filters and then open it again to make the next choice. So the described issue it's not limited to only cities.

@IvdL22 @PixlTracer @vronk
Can we talk about this in a meeting? What should be the behavior and how much priority should this issue have?

@patrickakk
Copy link
Contributor Author

Discuss in Autumn as part of bigger review of filter process

@patrickakk
Copy link
Contributor Author

Maybe more advanced search box instead of filter.

@patrickakk
Copy link
Contributor Author

Removed from milestone, until review is done.

@vronk
Copy link

vronk commented Dec 6, 2023

will be tackled in #88

@vronk vronk closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working - Kind of issue frontend Front End - Part of application specsmissing Development can’t start because specifications are missing – Status of issue
Projects
None yet
Development

No branches or pull requests

4 participants