Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GeoMap component to include adaptive zoom for small polygons #12

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Mocca101
Copy link

Especially for the entity detail view for Archaeological sites it can happen that the polygon for the grave is so small, that it won't be visible on the normal zoom levels.
I propose two changes to remedy this:

  1. Increase the possible maximum zoom level for the detail view.
  2. Swap between displaying small polygons as points or their original representation, depending on the zoom level.

The current implementation is an idea, but I am very open for changes as I think it might be beneficial, to separate between the needs of the global and entity map.
At the moment the implementation only works for the entity view, as it reduces all geometry to a single point, this might be enough for viewing a single entity but definitely not if we've got multiple entities on the map.

@stefanprobst
Copy link

can you provide a link to an example entity which has this issue? thanks!

@Mocca101
Copy link
Author

can you provide a link to an example entity which has this issue? thanks!

Sure: https://openatlas-discovery-demo.acdh-ch-dev.oeaw.ac.at/en/entities/178530

@stefanprobst
Copy link

stefanprobst commented Feb 29, 2024

thanks!

for reference, this is the polygon in that example:

{
  "coordinates": [
    [
      [
        13.451995282,
        46.818657494
      ],
      [
        13.451997209,
        46.818661968
      ],
      [
        13.452019505,
        46.81865738
      ],
      [
        13.452017913,
        46.818652848
      ],
      [
        13.451995282,
        46.818657494
      ]
    ]
  ],
  "shapeType": "shape",
  "title": "01/72",
  "type": "Polygon"
}

to check: might be caused by precision (first two values after comma don't change). does setting tolerance or maxzoom change anything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants