-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parameters for basic handling of mods #11
Conversation
LGTM but I don't know Python so leaving the approval to someone else 😁 |
Could allow JSON and the IDs in the env, load the json first then append from env |
Sounds good, will do |
Name is only for human readability and not used by the server. I suggest to use only one environment variable to specify mods,
|
Workshop should use a volume to avoid redownload when container is recreated, for example To use the volume and separate workshop folder start the game with argument |
While I do agree with an option for specifying mod version in the GAME_MODS_IDS_LIST, and keeping them on a dedicated volume, I don't think removing an option to provide mods via a file is a good idea tbh. Managing dozens of mods only via one long ENV would be quite a pain. Also it allows potential outside mod managers to just generate file instead of compiling a long ENV string. Your call tho |
Would be good with an example environment variable in README for how to load mods. The Dockefile has no example so one has to read through the launch.py code. |
Co-authored-by: jonpas <[email protected]>
@Dahlgren re-review please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Lint failed though, I will take a look in an hr or two 👀 |
No description provided.