Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters for basic handling of mods #11

Merged
merged 19 commits into from
Nov 3, 2023
Merged

Conversation

sdsznsk
Copy link
Contributor

@sdsznsk sdsznsk commented May 30, 2022

No description provided.

@veteran29
Copy link
Member

LGTM but I don't know Python so leaving the approval to someone else 😁

@BrettMayson
Copy link
Member

Could allow JSON and the IDs in the env, load the json first then append from env

@sdsznsk
Copy link
Contributor Author

sdsznsk commented May 30, 2022

Sounds good, will do

@Dahlgren
Copy link
Member

Dahlgren commented May 30, 2022

Name is only for human readability and not used by the server.

I suggest to use only one environment variable to specify mods, GAME_MODS, which accepts either any version or specific version.

  1. Mods with any versions, GAME_MODS=5965770215E93269,59664C0CB36501CD
  2. Mods with specific versions, GAME_MODS=5965770215E93269=1.0.6,59664C0CB36501CD=0.3.0
  3. Mods with any and specific versions, GAME_MODS=5965770215E93269,59664C0CB36501CD=0.3.0

@Dahlgren
Copy link
Member

Workshop should use a volume to avoid redownload when container is recreated, for example VOLUME /reforger/workshop

To use the volume and separate workshop folder start the game with argument -addonDownloadDir /reforger/workshop

@sdsznsk sdsznsk changed the title Add parameters for basic handling of mods Draft: Add parameters for basic handling of mods May 30, 2022
@sdsznsk sdsznsk changed the title Draft: Add parameters for basic handling of mods Add parameters for basic handling of mods May 31, 2022
@sdsznsk
Copy link
Contributor Author

sdsznsk commented May 31, 2022

While I do agree with an option for specifying mod version in the GAME_MODS_IDS_LIST, and keeping them on a dedicated volume, I don't think removing an option to provide mods via a file is a good idea tbh. Managing dozens of mods only via one long ENV would be quite a pain. Also it allows potential outside mod managers to just generate file instead of compiling a long ENV string. Your call tho

launch.py Outdated Show resolved Hide resolved
launch.py Show resolved Hide resolved
@Dahlgren
Copy link
Member

Would be good with an example environment variable in README for how to load mods. The Dockefile has no example so one has to read through the launch.py code.

@sdsznsk sdsznsk requested a review from Dahlgren May 31, 2022 13:59
launch.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@jonpas jonpas added the enhancement New feature or request label Nov 1, 2023
@jonpas
Copy link
Member

jonpas commented Nov 1, 2023

@Dahlgren re-review please.

Copy link
Member

@Dahlgren Dahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sdsznsk
Copy link
Contributor Author

sdsznsk commented Nov 1, 2023

Lint failed though, I will take a look in an hr or two 👀

@jonpas jonpas merged commit 2d7cb57 into acemod:main Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants