-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Added features for dicoms : PatientName and images: isPhantom #6899
Merged
driusan
merged 43 commits into
aces:main
from
spell00:2020-08-11-AddFeaturesViewsFromDTO
Nov 9, 2020
Merged
Changes from 41 commits
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
d259d63
[API] Added isPhantom to images attributes
spell00 a1a7a79
[API] isPHantom typo corrected
spell00 f06d25c
[API] Add missing attributes from DicomTarDTO and ImageDTO
spell00 0acacb8
Adds new features to the integration test suite
spell00 3f17dbc
updating v0.0.4-dev doc
spell00 39b8495
Restore last lines
spell00 0f425c1
remove last commit
spell00 b27d62b
downgrade composer to latest 1.x branch
spell00 4f00cf4
[API] Added isPhantom to images attributes
spell00 19a5227
[API] isPHantom typo corrected
spell00 a74d354
[API] Add missing attributes from DicomTarDTO and ImageDTO
spell00 c2e859d
Adds new features to the integration test suite
spell00 14881b3
updating v0.0.4-dev doc
spell00 4bae556
Restore last lines
spell00 7fd7b8b
remove last commit
spell00 fe8bd6f
Merge branch '2020-08-11-AddFeaturesViewsFromDTO' of https://github.c…
spell00 93f391d
revert to previous commit 0f425c11cbce15edb7c2161006c28ae42d9f05dc
spell00 c8f08ee
Revert "[genomic_browser] upgraded module for react (#5835)"
spell00 04f966f
[API] Added isPhantom to images attributes
spell00 e94e1de
[API] isPHantom typo corrected
spell00 d7e1cd6
[API] Add missing attributes from DicomTarDTO and ImageDTO
spell00 bdd60b7
Adds new features to the integration test suite
spell00 49c2479
updating v0.0.4-dev doc
spell00 84c797d
Restore last lines
spell00 172ccae
remove last commit
spell00 2d52c2c
[API] Added isPhantom to images attributes
spell00 332416d
[API] isPHantom typo corrected
spell00 087bef6
Restore last lines
spell00 645bcb1
remove last commit
spell00 0a2e346
revert to previous commit 0f425c11cbce15edb7c2161006c28ae42d9f05dc
spell00 9bcc17c
Revert "[genomic_browser] upgraded module for react (#5835)"
spell00 bc711e6
remove last thing from bad rebase
spell00 92ffc45
Revert "remove last thing from bad rebase"
spell00 9b743a3
Revert "Revert "[genomic_browser] upgraded module for react (#5835)""
spell00 8c4b3f4
Revert "Revert "remove last thing from bad rebase""
spell00 495a60d
Revert "remove last thing from bad rebase"
spell00 f125da7
Revert "Revert "remove last thing from bad rebase""
spell00 4d3c890
reverting
spell00 f60443d
remove errors
spell00 a1a1fbc
Removing errors from rebase
spell00 dd202d3
last thing to finish clearing bad rebase
spell00 0c5321e
add version
spell00 9623b9b
remove files
spell00 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -52,8 +52,9 @@ class Dicoms | |
private static function _formatDicomTars(DicomTarDTO $dicom): array | ||
{ | ||
return [ | ||
'Tarname' => $dicom->getTarname(), | ||
'SeriesInfo' => array_map( | ||
'Tarname' => $dicom->getTarname(), | ||
'Patientname' => $dicom->getPatientname(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is changing the result for both 0.0.3 and 0.0.4-dev, it needs a version check. |
||
'SeriesInfo' => array_map( | ||
[ | ||
'self', | ||
'_formatSeries' | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -58,6 +58,7 @@ class Images | |
'OutputType' => $image->getOutputType(), | ||
'Filename' => $image->getFilename(), | ||
'AcquisitionType' => $image->getAcquisitionprotocol(), | ||
'IsPhantom' => $image->isPhantom(), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same |
||
]; | ||
}, | ||
$this->_images | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
Empty file.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Empty file.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to say this isn't valid js so it's going to be rendered as an error since it's in a JS block, but then I decided to check if it's valid js in my JS console..
....