Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Instrument_Status] Keep flag Required_elements_completed Up-to-date #9448

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

skarya22
Copy link
Contributor

@skarya22 skarya22 commented Nov 6, 2024

Brief summary of changes

  • Update Instrument_Status to calculate and update the Required_elements_completed flag again on load / save
  • CCNA has had a recurring issue where instruments could not be set to Data_entry = 'Complete' because Required_elements_completed was set to 'N' even though the elements were completed.

Testing instructions (if applicable)

  1. Find a completed instrument
  2. set Required_elements_completed = 'N'
  3. Open the instrument and see that it was changed to 'Y'

@driusan
Copy link
Collaborator

driusan commented Nov 11, 2024

Discussed in assignment meeting. This is happening because of code changes to the required elements on CCNA. The better solution is to write a script which calls this function when the code changes, rather than having side effects on load. @skarya22 to make changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants