Different error messages for invalid OpenNeuro dataset name or version, and for those not yet deployed on Github #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MontrealSergiy
changed the title
|
|
MontrealSergiy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes in OpenNeuro the most recent versions is not represented by any tag in the corresponding GitHub repository, for example [ds003194 v1.0.4] (https://openneuro.org/datasets/ds003194/versions/1.0.4 ) updated 2022-09-20 while the corresponding Github repo was last updated in 2020 and end with tag 1.0.3 . There is at least another dataset with same glitch, ds003075. More, some OpenNeuro datasets do not have a single version on GitHub: see the OpenNeuro issue #3037 that tracks datasets not present on GitHub.
The present message is same for both cases of mistypes version and one that is not yet present on OpenNeuro.
This PR aims to give more appropriate message for both cases.
It seems like a OpenNeuro glitch, which we should escalate to their team, but OpenNeuro 'name and version' this issues may persist for a while.
To actually allows admin to download and configure dataset on alternative github organization/username see another PR #287
Note I downloaded v.1.0.4 using OpenNeuro client, and created my version of the DataLad repo at https://github.com/MontrealSergiy/ds003194