Fix tootip overlay closing. #1440
Conversation
Update bugfix to OICD generalization
|
Can you refer the issue(s) it is using by id or in Development section? |
|
Fix the #1433 |
|
The request recommends to use logic more similar to task help, but the PR still resolves the issue, even though behaviour of 'more' control diverges from the rest of cbrain. Perhaps, for the case of multiple windows I would add somewhere a button "close all info-cards". The page reload will close all the open cards, yet in our mobile age fewer and fewer users understand what reload button is for.
|
Can you let me know which pageS you are referring to ? |
|
for example, https://portal.cbrain.mcgill.ca/tools |
|
It have the same behaviour on both page ( i just tested, let me know if it is not the case). Also I look in the CBRAIN portal and notice some strange behaviour on the tool page:
Will look at it, |
|
Ok, you are right. I guess I just do not like that more element. The fix to tool page can then go to a separate issue/pr |
| flash[:error] = "You cannot change the password for your account." if attr_to_update[:password].present? | ||
| # Do not update password if user must use globus (or other oidc) | ||
| if user_must_link_to_oidc?(@user) && attr_to_update[:password].present? | ||
| flash[:error] = "You cannot change the password for your account because you should use OpenID." if attr_to_update[:password].present? |
There was a problem hiding this comment.
not sure how OpenID relates to tootips
There was a problem hiding this comment.
It´s not by bad, I will untangle my PR.
Multiple little feature:
html_tool_tip.closeat the bottom of thehtml_tool_tiphtml_tool_tipwhen mouseenter only if no other are open.html_tool_tiponly if click on the link insteadmouseenter