-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spoof newer Touchpad for Sequoia #26
Conversation
macOS Sequoia dropped the IOKit personalities for all the SPI touchpads, including the one used by VoodooInput.
This comment was marked as spam.
This comment was marked as spam.
Just raise a concern if 0x265 still works in Recovery mode, which was a problem years ago before VoodooI2C/VoodooI2C@3f00f01. So sorry that I can't test this due to my broken hack. |
Is it possible this breaks older macOS? |
Catalina recovery seemed to work just fine but I have no clue about older macOS recovery installs. I also don't think this would break older macOS version as the MT2 was introduced around 10.11. I can go ahead and try to find a newer touchpad product ID though and switch it based off of version. That way we use an embedded touchpad product ID instead of an external USB/BT one. |
@1Revenger1 The change looks good. If you can address @stevezhengshiqi and @vit9696's comments, then I am good with this PR. |
I changed it to use internal touchpads instead of the MT2. This should keep the old behavior for older OSes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll wait for @vit9696's thoughts on this, but this is good by me.
I built kexts with both 0x265 and 0x281 IDs, and got slightly smoother performance when using 0x265, and there were some random pointer movements when using 0x281. Is this behavior expected? Or, there may be some problem with my laptop's trackpad/it must be a one-off thing that happened to me 🤔 If anyone wants, the kexts can be found in the workflow artifacts - https://github.com/vedantmgoyal9/VoodooInput/actions |
It should make no difference. The underlying code is still the same, unless you can measure (say CPU load or some other metric), this is more than likely a placebo. |
The VoodooInput with ID 0x281 is superior to VoodooInput 1.1.4(ID 0x272). On Windows, my touchpad operates at a polling rate of 60Hz. On Sonoma, with VoodooInput 1.1.4(ID 0x272), the polling rate is 30Hz. However, with this VoodooInput using ID 0x281 on Sequoia, the polling rate is 60Hz. There isn't a very noticeable difference in usage, but it is an improvement. |
|
Spoofs a newer touchpad. macOS Sequoia dropped the IOKit personalities for the older SPI touchpads, including the one used by VoodooInput.